Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fontawesome v6 #4020

Merged
merged 2 commits into from
Sep 20, 2024
Merged

feat: fontawesome v6 #4020

merged 2 commits into from
Sep 20, 2024

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Sep 19, 2024

Changes proposed in this pull request:

  • Upgrades Fontawesome to v6, for this to work we have to drop importing the LESS files and instead import vanilla CSS files of fontawesome. I have found no issues with this apart from having to apply the assets fonts path by applying a replace on the final parsed CSS.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9 SychO9 requested a review from a team as a code owner September 19, 2024 16:31
@SychO9 SychO9 added this to the 2.0 milestone Sep 19, 2024
@SychO9 SychO9 self-assigned this Sep 19, 2024
@SychO9 SychO9 merged commit f13a1c8 into 2.x Sep 20, 2024
25 checks passed
@SychO9 SychO9 deleted the sm/FA-6 branch September 20, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant